phf: + int64* pnSleepTime = new int64(params[1].get_int64());

phf: - int* pnSleepTime = new int(params[1].get_int());

phf: LEAVE_CRITICAL_SECTION(cs_nWalletUnlockTime);

phf: ENTER_CRITICAL_SECTION(cs_nWalletUnlockTime);

phf: http://btcbase.org/log/2018-02-24#1785862 << that's the idea, but __attribute__ is a gcc specific feature. i'd like to have a catalog of such extension because i noticed there's few more here and there ☝︎

phf: also make vdiff `-D_Noreturn=__attribute__\\\((noreturn\\\))' is even better work around, but the combination of shell/makefile seems to pass the parenthesis through on bash but not on zsh... ☟︎

phf: and both 4.6 and 4.4 refuse to compile it. a temporary workaround is to compile with `make vdiff -D_Noreturn='

phf: http://btcbase.org/log/2018-02-23#1785630 << so offending attribute is _Noreturn, which is a c11 feature that was only introduced in 4.7. but! i tested with 4.6.4 on freebsd before release, i now also compiled 4.4.3 and it still works. running cpp-4.4 on the file it looks like something in freebsd headers actually replaces _Noreturn with an __attribute__ call that older gcc's support. with a test file with `void _Noreturn foo() {...}' but without any includes, ☝︎