17700+ entries in 0.041s
mod6: <+mircea_popescu> not a great fan of vchSig and bs myself, eother. << yeah, im not sure why the var name needs to delcare that it is a vector of chars.
mod6: i would agree there, but on the basis that the comments are accurate in a technical sense. nothing worse than misleading comments or documentation, as we've recently discussed.
mod6: <+mircea_popescu> specifically, imagine a future in which every line of code has 100 lines of commentary, much like the talmud (which is a VERY proper comparison) << I never thought of it this way.
mod6: <+asciilifeform> i often wonder, do these folks also have two-metre-wide toilet in the house, so as to not miss ? << i lel'd
mod6: thanks for all of your comments this morning. I appreciate everyone taking a look at this one.
mod6: yah, i better remove those.
mod6: does anyone have any pref on the commented out DEBUG statements for the finalized one? just remove them?
☟︎ mod6: so that should be fine.
mod6: oh yeah, derp. so in yours it will just skip the compare and if true, subtract sections.
mod6: oh i totally agree. its just an old wart.
mod6: also, about
http://dpaste.com/26VKRQG : I left the original code in Sign(...) in the } else { case because i thought it be necessary to have a default. if we don't have one, it forces the user to pick -highs -lows every single time they execute.
mod6: oh hmm. i think i put in some spaces in there.
mod6: <+mircea_popescu> asciilifeform
http://dpaste.com/26VKRQG << re: There is no reason to test for both highS and lowS being set, because this is tested in init.cpp already, ... << For some reason I had it in my head that since this gets set in util.h/.cpp that both may become set at some point post execution if someone does something funny.
mod6: <+asciilifeform> if (fHighS && (BN_cmp(sig->s, halforder) < 0)) <+asciilifeform> generally i like to avoid hastening ulcers if possible << yeah, i dont know why I didn't do this to begin with. Heheh.
mod6: Sorry about the spaces in there where I put in my changes, I can and will fix that for my changes. And yeah, I think post-release it may not be a bad idea to do a one-time-cleanup of all of that.
mod6: third high-s tx was malleated also, went through, was confirmed as were previous two
mod6: DEBUG DER S: 0xC541A295514D6BF4BEF30599DC7F8A18BEC9B6B3F615D94F847AD154D4DCBB45 << is not
mod6: DEBUG DER R: 0x11E986930067BA31716E2D880F6660ABFC3C7C6927C94E0AF6CB4C0CD6315D5B << is found in hex
mod6: this one looks malleated too
mod6: ok second high-s tx went through
mod6: maybe it'll get picked up eventually.
mod6: oooo crap forgot to set the fee to 0.001 after restarting.
mod6: this is interesting... that tx '893d003f806a5bce121a71e84c260e7879cb6c5464ef93132c0b79e60ff7ff66' hasn't been confirmed yet
mod6: yeah, but i guess thats to be expected since these three are supposed to all be high-s.
mod6: DEBUG DER R: 0xB16F69B135317A54C96C0EA8882C295DB05B7BD4598FDE42865983A1AEBB3E63
mod6: my S value spit out into the debug.log isn't contained in the hex data in the tx: DEBUG DER S: 0xBE8E2E74EBE2618A27D50E0A1D02B33BCE8188940AA22967E9E01AD4D140AB0F
mod6: im pretty sure that one was mallated.
☟︎ mod6: first high-S tx went through o_O
mod6: dear lord, i've had like 9 crackers with cheddar today and like 3 mtdews.
☟︎ mod6: alright, now for the high-S txn
mod6: alrighty, 3rd low-S tx made it through
mod6: else { char *classic = "trb"; }
mod6: 2nd low-s tx went through
mod6: hey waddya know, i've got a block before btc.blockr.io
mod6: if(SHITGNOMES) { char *classic = "manyRadicalDeltasFromPointOfOrigin"; }
mod6: WE have bitcoin "classic", not these pinwheels
mod6: wtf is bitcoin classic?
mod6: first low-s tx made it through.
mod6: (a work in progress)
mod6: im gonna do 3 per option: orig/low/high
mod6: another dropped on the floor.
mod6: first tx with original code went through np.
mod6: just kinda documenting here a bit.
mod6: yeah, im sure it never made it out
mod6: here's the tx: bf990fa50a4ea2c13dbe8f65c42c5fcb7b3439109b0c2d0e22081960a9c5fe9a
mod6: mircea_popescu: eh, ya. but worthwhile.
mod6: this test tx was processed by the original code.
mod6: i got another tx dropped on the floor. im also 2 blocks behind, so not sure if it cares.
mod6: ;;later tell pete_dushenski Salud!
mod6: i guess this is funny because back when I first started writing code, a hundred million internet years ago, i liked the first way better.
mod6: guess its just a personal pref. *shrug*
mod6 is not a fan of the style used in here
mod6: ok changes made. gonna recompile send some test txn, then if all *seems* well, will share my vpatch
mod6: thanks for asking. i just went through my high-S enforcement code by hand, and i know for sure that I have an error in there. about to fix it and try that out.
mod6: you never know when you might need to fit 7 hookers in the car.
mod6: its a pretty nice vehicle. its like all the power of a full-size truck with some extra seating.
mod6: and there were some sort of vermin living in there.
mod6: i guess im just happy that i have windows that roll up and heat. that old shitter that i got for free (basically) was pretty cold driving down the freeway at 65mph when it's -25 F.
mod6: yeah, a bit. the new ones look even less curvy than mine,... more of a boxy look
mod6: new ones are like seventyfive racks
mod6: pete_dushenski: thx, it's old '08
mod6: (instead of 9.99.97) ?
mod6: just still has version 9.99.99 or whatever it is?
mod6: does bitcoind start, even if the verstring doesn't change?
mod6: we'll get it figured out
mod6: paste your command string in here.