16500+ entries in 0.028s
mod6: i did vdiff of the pressed out stuff.
mod6: scroll to the bottom.
mod6: please explain again so i can get this completed.
mod6: ascii_butugychag: is this kinda what you were asking for yesterday? A vdiff of a pressed original patches (minus PVS fix) + shiva with pressed mod6's integrated patch + malleus regrind + shiva ?
mod6: trinque: what version of bitcoin?
mod6: ;;later tell funkenstein_ thanks. yeah, that patch will be useful. will try to get it in right after the release.
mod6: oh awesome, did it make it into the ML?
mod6: funkenstein_: hey, did you write that one?
mod6: meanwhile, I'll work on an automated test for this change and work on republishing this fix as a one change deal. will be v99995
mod6: ok, well, we can worry about that later when we write our own patch-o-matic
mod6: thats what i gather too.
mod6: ascii_butugychag: hey, can you take a look at this? i pressed up to the vpatch in the flow before polars then.. manually patched with -F 0, but didn't seem to do anything:
mod6: im testing the wrong fucking scalar in my condition :<
mod6: when you press, if the hash of the pressed file doens't match the expected, it should die right then and there.
mod6: i know at one point i did negitive tests on this, but my problem in there is idiotic, i was not paying close enough attention
mod6: i've got some idiotic thing going on in there, looking now.
mod6: here's a debug snippit
mod6: and.. even if it does press, it should have immediately haulted when it saw this:
mod6: it does press, yes, but it shouldn't
mod6: the output hashes of net.h/net.cpp/bitcoinrpc.cpp are not matching the vpatch at all, this should have died mid press.
mod6: man, v is failing badly.
mod6: im just trying to be sure, im already pretty sure... but i wanted you to look/test so i dont end up with more on my plate
mod6: before i re-grind this patch, im gonna look into V a bit while I wait for ascii to give me the green light on the other two reground from lastnight.
mod6: but that could be somehow broken as well, obviously, this needs some attention.
mod6: it verifies the post press checksum.
mod6: and yah, its certainly flawed.
mod6: right this is actually a really good test case.
mod6: no worries, they need to be re-ground, i'll work on that.
mod6: mircea_popescu: ahh, ok.
mod6: and thats even with a full sync of the mirror as it exists up until this very minute.
mod6: still needs to be re-ground, but was just weird that it had no matching antecedents
mod6: ah, so this is what is very weird:
mod6: !up ascii_butugychag
mod6: or at least until i give the "all good" signal in here.
mod6: if anyone else is in the middle of creating a patch - maybe hold off a day or so before you submit until I can straighten out the tree & test everything.
mod6: this one needs to be reground
mod6: looks like it compiled fine -- even though the patch had to apply with Hunk offset garbage
mod6: will find out here in a minute
mod6: and that might be because i'm running with my two replacement patches for ascii's stuff that haven't been verified yet.
mod6: whats weird here, is that the hashes in the patch, before and after, match nothing that i've got. so i've gotta figure that out.
mod6: something is wrong with that patch, and V isn't doing anything about it.
mod6: you may wanna hold off for a minute
mod6: no idea how you got v-0001.pl tho
mod6: yah, that's the right one.
mod6: afaik i've always named the actual file `v.pl'
mod6: <+mircea_popescu> mod6 why is your v perl implementation named v0001.pl on ml instead of a saner v99996 ? << weird? where do you see that?
mod6: !up ascii_butugychag
mod6: !up ascii_butugychag
mod6: !up ascii_butugychag
mod6: i don't have tinyscheme-genesis in my patches dir. just shiva 1_of_2 and shiva 2_of_2 + the shiva fix.
mod6: here's a screenshot of the graph after the fix was applied (locally):
mod6: shiva did expose a defect in v99996 of V (line 420), in one of the graphing subroutines (add_desc_src_files). the rest is fine. locally added simple conditinal check to see if the node is empty seems to have fixed it.
mod6: we're about to get some snow. not as bad as IA tho.
mod6: give these a compile & quick test if you don't mind and then upon confirmation, I'll update the mirror.
☟︎☟︎ mod6: asciilifeform: hey, ok posted those two to the mailing list:
mod6: Bitcoin version 0.9.99.98 << good
mod6: lemme compile & test with the new patches + shiva 1 & 2 + fix
mod6: actually, i think we're ok here because the only parts that changed in the new patches are main.cpp and serialize.h
mod6: be back in a few to sort out the patches that need re-grind after I submit the integrated programmable-version-strings vpatch and the reground mikehearn one
mod6: #>(btc-get-best-height)
mod6: ok so pressed out shiva with V -- used what is currently in the mirror (including alfs PVS) + what is stated above: shiva 1 & 2 + shiva fix, compiles and works:
mod6: whenever is cool. :]
mod6: try it out, grab v99996, grab alfs expired key and drop it in your .wot
mod6: you know, im pretty sure that my v ignores expired keys.
mod6: the history you don't know... or how does it go?
mod6: i didn't know he was a crypto guy
mod6: in the case of v, if she had created a patch, and she was the only one who signed it and her key expired tomorrow, well, someone better grok it and sign it who's in the current lordship