345300+ entries in 0.208s
mircea_popescu: asciilifeform
there's a raft of cosmetic/credible fixes between .5 and .6.
polarbeard: ben_vulpes: for looking
to
the lines above and below and use
that as
the defaults
assbot: Logged on 25-01-2016 01:58:21; mod6: I'm not an expert on
the openssl internals. If you
think I should not
trust ECDSA_do_sign and reimplment with ECDSA_sign, I can.
mircea_popescu: asciilifeform perhaps rejecting workers because
they forgot
to wipe
their ass
this morning also ?
polarbeard: ben_vulpes: lol, vi... I mean notepad.exe has a plugin for
that
mircea_popescu: hey, if
the change is not obviously a good
thing it's probably a bad idea. it pisses me
the fuck off, but whatevs, i'll sed or something.
ben_vulpes: only reasonable style guide for
this codebase is "make it look like
the lines immediately above and below"
mircea_popescu: asciilifeform well, if
there's no consensus,
there's no consensus and
there it goes.
assbot: And Gavin moves on
to
the dark side.
The Bitcoin project is officially hijacked on
Trilema - A blog by Mircea Popescu. ... (
http://bit.ly/1MvB8Kx )
ben_vulpes: i am still anti-tab, delimiter
token hoojaberry aside
mircea_popescu: the do version ultimately returns return ecdsa->meth->ecdsa_do_sign(dgst, dlen, kinv, rp, eckey); while
the no-do version just calls
the do version.
assbot: Logged on 25-01-2016 02:22:44; mircea_popescu:
this'd be
the last juncture at which people who seriously and staunchly are against
the space
to
tab switch should raise hell.
ben_vulpes: right but if we stick
to
the old impl
the audit is no longer required.
BingoBoingo: <danielpbarron> yeh, so is
this still a qntra article or..? << If you submit something with all of
the point brought up it channel, its chance of publication is a weighted coinflip. Depends what you can make of it.
mircea_popescu: the difference between
the
two, incidentally, is not
trivial.
ben_vulpes: i will point out
that changing
to
the wrapper implementation implies audits
to be done of
the implementation delta.
mircea_popescu: fancy
that, someone actually
thought
this is how you design a function stack.
mircea_popescu: thestringpuller verification of any functional kind is
the sworn enemy of anyone with phds.
thinkaboutit.
mircea_popescu: must point
to ECDSA_size bytes of memory,
the parameter
type ~is ignored~). Meanwhile ECDSA_do_sign_ex() computes a digital signature of
the dgst_len bytes hash value dgst using
the private key eckey and
the optional precomputed values kinv and rp.
The signature is returned in a newly allocated ECDSA_SIG structure (or NULL on error).
mircea_popescu: ECDSA_sign() is wrapper function for ECDSA_sign_ex with kinv and rp set
to NULL ; ECDSA_do_sign() is wrapper function for ECDSA_do_sign_ex with kinv and rp set
to NULL. ECDSA_sign_ex() computes a digital signature of
the dgstlen bytes hash value dgst using
the private EC key eckey and
the optional pre-computed values kinv and rp.
The DER encoded signatures is stored in sig and it's length is returned in sig_len. (sig
assbot: Logged on 25-01-2016 01:36:11; asciilifeform: what's
the diff b/w 'ECDSA_sign' and 'ECDSA_do_sign' ?
ben_vulpes: mircea_popescu:
thoughts on ecdsa calls?
thestringpuller: so.
they
took out verifyall in core bitcoind and replaced it with -reindex. -reindex doesn't disregard checkpoints. or at least no one knows if it does or not. how do
these people have Ph.D's and shit?
polarbeard: 'corel devs did
that on purpos
to split
the comuniteh!'
assbot: Logged on 25-01-2016 01:34:57; mod6: i believe my implementation
to be correct.
ben_vulpes: entire code base is almost guaranteed
to be in conflict with any style guide unfortunately.
mod6: yeah, and
this should make it all easier going forward
to create
the vpatch. overall, a good move sooner rather
than later imho.
mircea_popescu: this'd be
the last juncture at which people who seriously and staunchly are against
the space
to
tab switch should raise hell.
☟︎ mod6: im sure i might need some more guidence when I get
to working on
that part, but we can cross
that bridge when we come
to it.
mod6: agreed. let's
try
to keep it just down
to
the
tabs for now.
mircea_popescu: stuff like { much easier
to fix as patches/code is reviewed, by and by.
mircea_popescu: and while it'd be
tempting
to overload it with stuff like moving
the {, i would
think it's better not
to. make it simple and sweet
to check.
mircea_popescu: so we'll have
the 99996 > 99995 be "all
tabulation, machine checkable"
mod6: Yeah, sounds good.
Thanks, want
to get all of
this done in a sane order and
timely fashion.
mircea_popescu: oh ok, my bad. so what i was
thinking here is : a) finish
the patch ; b) do all
the other stuff you were going
to do in your own
time ; c) when ready make a new version ; d)
take a week off, during which everyone [who cares
to] can write and run a script
to / /
mod6: (a vpatch
to
tie
them all
together)
mod6: But it probably would have been
the last
thing
to go into
the
tree before a release patch.
mircea_popescu: i guess i unwittingly confused you, sorry about
that.
the S-patch was not actually intended
to mark a new release did it ?
mod6: Ok. I can get
that done
tonight yet.
aknix: was actually just seeing if
the channel was public again. Used
to stop by now and
then.
mod6: Ok sounds good mircea_popescu. I'll stop my current work on
the high/low patch. I'll spend
this week getting
the changes [.wot in
the pwd, and mechanical post-patch hash checking] in V [v99996] released.
Then I'll immediately begin work on a re-alignment of all
the patches we currently are distributing.
assbot: Logged on 25-01-2016 01:23:27; mod6: so what we want, is
three different ways: no force one way or another, force high, or force low. remember, i originally didn't want
to do a force high at all. but since asciilifeform requested
this, i'm entertaining
this option.
assbot: Logged on 25-01-2016 01:10:06; mod6: And
then we can re-align post release.
mircea_popescu: so you get a week off or something, during which people just run
teh script and sign
the results.
assbot: Logged on 25-01-2016 01:04:29; mod6: mircea_popescu, asciilifeform, ben_vulpes et. al., any further
thoughts if we should clean up
the code alignment (currently with spaces) post release and do a one-time clean up with
tabs?
ben_vulpes: mod6: are you referring
to fixing
the magic numbers?
ben_vulpes: perhaps fixing magic numbers is out of scope for a patch
to force s-values?
mod6: not sure what
to do abut
this
tho:
ben_vulpes: that'd be closest
to
the original code
mod6: i suppose if we continue
to use ECDSA_sign, we can continue
to use: memcpy(&vchSig[0], pchSig, nSize);
mod6: I'm not an expert on
the openssl internals. If you
think I should not
trust ECDSA_do_sign and reimplment with ECDSA_sign, I can.
☟︎ assbot: Logged on 21-01-2016 15:20:05; mod6: does anyone have any pref on
the commented out DEBUG statements for
the finalized one? just remove
them?
mod6: there was a discussion around
this, and decided
to leave
them in as a result. will dig up...
mod6: so
the deal
there is
that was just some debugging info --
that may be useful
to someone at some point.
ben_vulpes: mod6: what's
the rationale behind including
the commented out printfs?
ben_vulpes: gah
this return value shit is hilarious
ben_vulpes: appears
to be a wrapper around do_sign
to some extent or another
ben_vulpes: which is not
the blessed openssl, but...
mod6: i believe my implementation
to be correct.
☟︎ mod6: i
think
there seems
to be questions around why i have
two booleans.